Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: npm link should override --install-links #5633

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

fritzy
Copy link
Contributor

@fritzy fritzy commented Oct 4, 2022

No description provided.

@fritzy fritzy requested a review from a team as a code owner October 4, 2022 11:00
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Oct 4, 2022

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 40.246 ±1.67 21.955 ±0.05 19.878 ±0.20 23.434 ±2.26 3.583 ±0.13 3.754 ±0.21 2.771 ±0.04 14.041 ±0.50 2.917 ±0.03 4.777 ±0.88
#5633 40.670 ±0.41 21.814 ±0.61 19.872 ±0.06 23.080 ±0.94 3.598 ±0.15 3.558 ±0.02 2.786 ±0.11 13.917 ±0.17 2.893 ±0.07 4.152 ±0.00
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 29.236 ±1.61 17.069 ±0.29 15.132 ±0.14 16.499 ±0.16 3.311 ±0.02 3.249 ±0.03 3.056 ±0.24 10.623 ±0.32 2.787 ±0.06 3.628 ±0.12
#5633 29.086 ±0.95 17.029 ±0.05 15.487 ±0.22 16.405 ±0.19 3.217 ±0.05 3.210 ±0.07 2.858 ±0.10 10.779 ±0.26 2.646 ±0.03 3.596 ±0.03

test/lib/commands/link.js Outdated Show resolved Hide resolved
@fritzy fritzy force-pushed the fritzy/link-cmd-always-link branch 2 times, most recently from d9f09e1 to f0a6abe Compare October 4, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants