Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libnpmpack): obey ignoreScripts #5651

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

winterqt
Copy link
Contributor

@winterqt winterqt commented Oct 6, 2022

Per config:

If true, npm does not run scripts specified in package.json files.

Note that commands explicitly intended to run a particular script, such as npm start, npm stop, npm restart, npm test, and npm run-script will still run their intended script if ignore-scripts is set, but they will not run any pre- or post-scripts.

References

None

@winterqt winterqt requested a review from a team as a code owner October 6, 2022 00:28
@winterqt winterqt mentioned this pull request Oct 6, 2022
13 tasks
@wraithgar
Copy link
Member

Just one test nitpick. This one certainly went much more smoothly than the last one lol.

@wraithgar wraithgar self-assigned this Oct 6, 2022
@fritzy fritzy merged commit a990c3c into npm:latest Oct 12, 2022
@winterqt winterqt deleted the pack-obey-ignore-scripts branch October 12, 2022 18:30
@winterqt
Copy link
Contributor Author

Wonder why this wasn't mentioned in the changelogs, but my previous PR was. 🤔

Thought this wasn't included in v9 for a second, haha.

@wraithgar
Copy link
Member

Yeah the changes in workspaces themselves show up in their respective changelogs. We're still looking into a good way to bubble those up to the cli w/o having to have EVERY change from EVERY dependency end up in the changelog too.

@winterqt
Copy link
Contributor Author

So, just out of curiosity, how did the ignoreScripts change bubble up to the cli changelog? Was that done manually or something?

@wraithgar
Copy link
Member

That change was in 5.0.0-pre.3 of libnpmpack, which was a dependency update in 9.0.0-pre.5 of npm

@wraithgar
Copy link
Member

All of our changelog entries are automated via release-please through github actions.

#5689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants