-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add --expect-results and --exepect-result-count to npm query
#5966
Conversation
found 1 benchmarks with statistically significant performance improvements
found 1 benchmarks with statistically significant performance regressions
timing results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
b00d21e
to
c7dc71d
Compare
Rebased onto |
c7dc71d
to
8cb1ab2
Compare
i pushed a commit converting to the new test config format which uncovered an interesting bug. the config type definition is converting all numbers to booleans (https://github.com/npm/cli/actions/runs/3820159448/jobs/6498253762#step:7:70). with nopt there doesn’t seem to be a way to make a config that can be both a number and boolean that i could find? |
Well fiddlesticks, that's frustrating. We'll have to either get creative or ditch the numbers for now. |
So far from what I've seen discussed, the big asks have been for boolean, and for "more than one entry" (think react hoisting). |
39911ae
to
1d7de6a
Compare
npm query
npm query
871ddc9
to
afd9cc8
Compare
This will allow users to tell npm whether or not to exit with an exit code depending on if the command had any resulting entries or not.
afd9cc8
to
be48f17
Compare
be48f17
to
86e6fce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with one question that is not a blocker.
This will allow users to tell npm whether or not to exit with an exit
code depending on if the command had any resulting entries or not.