Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor engines validation to lint syntax #6479

Merged
merged 1 commit into from
May 22, 2023
Merged

fix: refactor engines validation to lint syntax #6479

merged 1 commit into from
May 22, 2023

Conversation

lukekarrys
Copy link
Contributor

No description provided.

@lukekarrys lukekarrys requested a review from a team as a code owner May 20, 2023 00:10
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented May 20, 2023 •
edited
Loading

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit		 show-version run-script
npm@9 46.194 ±1.57 25.194 ±0.43 24.132 ±0.50 26.268 ±0.37 3.887 ±0.16 3.581 ±0.14 3.070 ±0.01 16.926 ±0.46 3.160 ±0.05 4.413 ±0.15 0.494 ±0.03 0.502 ±0.01
#6479 45.220 ±3.16 25.245 ±0.53 24.835 ±0.30 28.106 ±0.18 3.911 ±0.09 3.831 ±0.05 3.260 ±0.14 17.013 ±0.57 3.243 ±0.09 4.665 ±0.30 0.463 ±0.00 0.510 ±0.02
app-medium clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit		 show-version run-script
npm@9 32.870 ±0.09 18.491 ±0.42 18.158 ±0.24 19.179 ±0.27 3.586 ±0.04 3.469 ±0.04 3.179 ±0.00 12.201 ±0.16 3.014 ±0.06 4.193 ±0.11 0.497 ±0.00 0.531 ±0.00
#6479 32.944 ±1.07 19.023 ±0.34 17.674 ±0.12 19.262 ±0.34 3.499 ±0.06 3.441 ±0.04 3.179 ±0.02 12.683 ±0.05 3.120 ±0.01 4.239 ±0.01 0.491 ±0.02 0.527 ±0.02

@lukekarrys lukekarrys force-pushed the lk/validate-engines-lint branch from 3e6b2a8 to 8b5ee0a Compare May 20, 2023 00:33
@lukekarrys lukekarrys force-pushed the lk/validate-engines-lint branch from 8b5ee0a to c336cd8 Compare May 21, 2023 20:29
wraithgar
wraithgar reviewed May 22, 2023
View reviewed changes
lib/cli.js Show resolved Hide resolved
@wraithgar wraithgar merged commit 4f39e8c into latest May 22, 2023
@wraithgar wraithgar deleted the lk/validate-engines-lint branch May 22, 2023 15:57
@github-actions github-actions bot mentioned this pull request May 22, 2023
Merged
@lukekarrys lukekarrys mentioned this pull request May 22, 2023
Merged
lukekarrys added a commit that referenced this pull request May 22, 2023
@lukekarrys
chore: separate cli-entry and cli tests
2a0bd65 
This is cleanup from #6479. Everything is being tested the
same as before, but this fixes the EventEmitter max listeners
warning that was happening because exit-handler was not being
mocked properly
wraithgar pushed a commit that referenced this pull request May 22, 2023
@lukekarrys
chore: separate cli-entry and cli tests (#6489)
e580d94 
This is cleanup from #6479. Everything is being tested the
same as before, but this fixes the EventEmitter max listeners
warning that was happening because exit-handler was not being
mocked properly
@npm-cli-bot npm-cli-bot mentioned this pull request Jun 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukekarrys @npm-cli-bot @wraithgar