Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version: using 'allow-same-version', git commit --allow-empty and git tag -f #648

Closed
wants to merge 2 commits into from

Conversation

rhengles
Copy link
Contributor

@rhengles rhengles commented Jan 1, 2020

What / Why

When running npm version "x.x.x" --allow-same-version, it often is the case that git commit will fail because there are no changes to commit, and that git tag vx.x.x will fail because the tag already exists.

The changes here are exactly these to prevent failure only when the option allow-same-version is activated.

@ruyadorno
Copy link
Contributor

hi @rhengles, this does looks good! can you please add some tests? 😊

@ruyadorno ruyadorno added pr: needs tests requires tests before merging Release 6.x work is associated with a specific npm 6 release semver:patch semver patch level for changes labels Jan 6, 2020
@rhengles
Copy link
Contributor Author

rhengles commented Jan 7, 2020

@ruyadorno Thank you! I'll arrange that.

@rhengles
Copy link
Contributor Author

rhengles commented Jan 7, 2020

@ruyadorno Done! Let me know if this is good.

@rhengles rhengles closed this Jan 8, 2020
@rhengles rhengles reopened this Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release 6.x work is associated with a specific npm 6 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants