Fix a few lgtm.com issues.

lib/cache.js

@@ -38,7 +38,7 @@ cache.completion = function (opts, cb) {
   }
 }
 
-exports = module.exports = cache
+module.exports = cache
 function cache (args, cb) {
   const cmd = args.shift()
   let result

lib/install/deps.js

@@ -463,7 +463,7 @@ function andHandleOptionalErrors (log, tree, name, done) {
     if (!er) validate('OO', [child, childLog])
     if (!er) return done(er, child, childLog)
     var isFatal = failedDependency(tree, name)
-    if (er && !isFatal) {
+    if (!isFatal) {
       reportOptionalFailure(tree, name, er)
       return done()
     } else {

lib/ls.js

@@ -4,7 +4,7 @@
 // <fullpath>:<name@ver>:<realpath>:<flags>
 // Flags are a :-separated list of zero or more indicators
 
-module.exports = exports = ls
+module.exports = ls
 
 var path = require('path')
 var url = require('url')

lib/npm.js

@@ -376,7 +376,7 @@
 
         startMetrics()
 
-        return cb(null, npm)
+        return cb(null)
       })
     })
   }

lib/outdated.js

@@ -108,7 +108,7 @@ function outdated (args, silent, cb) {
       if (opts.json) {
         output(makeJSON(list, opts))
       } else if (opts.parseable) {
-        output(makeParseable(list, opts))
+        output(makeParseable(list))
       } else {
         var outList = list.map(x => makePretty(x, opts))
         var outHead = [ 'Package',

lib/search.js

@@ -1,6 +1,6 @@
 'use strict'
 
-module.exports = exports = search
+module.exports = search
 
 const npm = require('./npm.js')
 const allPackageSearch = require('./search/all-package-search')

lib/utils/gently-rm.js

@@ -1,7 +1,7 @@
 // only remove the thing if it's a symlink into a specific folder. This is
 // a very common use-case of npm's, but not so common elsewhere.
 
-exports = module.exports = gentlyRm
+module.exports = gentlyRm
 
 var gentleFS = require('gentle-fs')
 var gentleFSOpts = require('../config/gentle-fs.js')

lib/utils/lifecycle-cmd.js

@@ -1,4 +1,4 @@
-exports = module.exports = cmd
+module.exports = cmd
 
 var npm = require('../npm.js')
 var usage = require('./usage.js')

lib/utils/lifecycle.js

@@ -1,4 +1,4 @@
-exports = module.exports = runLifecycle
+module.exports = runLifecycle
 
 const lifecycleOpts = require('../config/lifecycle')
 const lifecycle = require('npm-lifecycle')

lib/utils/read-local-package.js

@@ -1,4 +1,4 @@
-exports = module.exports = readLocalPkg
+module.exports = readLocalPkg
 
 var npm = require('../npm.js')
 var readJson = require('read-package-json')