Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(update): Replace comma with period in run on sentence #7142

Merged
merged 2 commits into from
Jan 19, 2024

Commits on Jan 16, 2024

  1. Replace comma with period in run on sentence

    - I also removed the word "direct" in the phrase "direct dependencies." To be honest, I'm not sure if this change was correct; I don't know what the differences between a "dependency" and a "direct dependency," and I'm hoping to learn through feedback on this PR.
    
       - If "direct" means "not transitive," I don't think any clarity is lost by my modification. I'd even argue this change adds clarity and may expose a missing detail: what happens to transitive dependencies when you `npm update`? Of course, that question is built on top of assumptions; I'm hoping that sharing what I was thinking at the time could help others in reviewing my change.
    DanKaplanSES committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    707e57e View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Configuration menu
    Copy the full SHA
    8200d80 View commit details
    Browse the repository at this point in the history