Remove more table output #7407
Merged
Remove more table output #7407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes table output from `npm search` and from all commands that log a summary of tarball content (`npm publish` and `npm pack`). Table output is discouraged in a cli for accessibility reasons.
lukekarrys
reviewed
Apr 23, 2024
lukekarrys
approved these changes
Apr 23, 2024
Merged
This was referenced Apr 25, 2024
fengmk2
pushed a commit
to cnpm/cnpmcore
that referenced
this pull request
Dec 18, 2024
### 改动原因 在今年 4 月份，npm cli 对 search 做了[一些改动]，在 4 月份以前(npm cli < `v10.6.0`)，采用的是 `maintainers` 字段，而在 npm/cli#7407 后，改为使用: `publisher` 字段。 导致当 npm 版本大于等于 `v10.6.0` 后，search 结果中的 `author` 将变成 `???`，如图：  预期的结果应该为:  ### 技术细节说明 当前改动没有为 `es` 增加新的索引，原因是处于以下考虑: 1. es 的 `mapping` 一旦创建，就无法修改（虽然使用了 `dynamic: true` 但无法细粒度的进行控制） 2. 源数据中的 `_npmUser` 已经有相关信息了，没有必要为此浪费额外的磁盘空间 3. 如果想对以前的数据进行更新会比较麻烦，性价比较低 npm cli 老版本: https://github.com/npm/cli/pull/7407/files#diff-4bc15933c685fc9a9ce8be0c13a2f067f5e2b3334bacd6664bdfa7ddc46aedb6L58 npm cli 新版本: https://github.com/npm/cli/pull/7407/files#diff-4bc15933c685fc9a9ce8be0c13a2f067f5e2b3334bacd6664bdfa7ddc46aedb6R162 ### 其他 相关 PR: #513 PTAL @Beace @fengmk2 @elrrrrrrr [一些改动]: npm/cli#7407 Signed-off-by: Kevin Cui <bh@bugs.cc>
fengmk2
pushed a commit
to cnpm/cnpmcore
that referenced
this pull request
Dec 18, 2024
[skip ci] ## [3.71.2](v3.71.1...v3.71.2) (2024-12-18) ### Bug Fixes * **search:** author is `???` in result ([#741](#741)) ([acffb14](acffb14)), closes [/github.com/npm/cli/pull/7407/files#diff-4bc15933c685fc9a9ce8be0c13a2f067f5e2b3334bacd6664bdfa7ddc46aedb6L58](https://github.com/cnpm//github.com/npm/cli/pull/7407/files/issues/diff-4bc15933c685fc9a9ce8be0c13a2f067f5e2b3334bacd6664bdfa7ddc46aedb6L58) [/github.com/npm/cli/pull/7407/files#diff-4bc15933c685fc9a9ce8be0c13a2f067f5e2b3334bacd6664bdfa7ddc46aedb6R162](https://github.com/cnpm//github.com/npm/cli/pull/7407/files/issues/diff-4bc15933c685fc9a9ce8be0c13a2f067f5e2b3334bacd6664bdfa7ddc46aedb6R162)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes table output from
npm searchnpm publishandnpm packAlso removes the
columnifydependency as it is no longer used.