Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline libnpmdiff color setter #7409

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Inline libnpmdiff color setter #7409

merged 2 commits into from
Apr 23, 2024

Conversation

wraithgar
Copy link
Member

Removes a tiny single-use library in favor of just doing it inline

Eventually npm will be where we set colors in output exclusively.

  • deps: remove @npmcli/disparity-colors
  • fix: inline color selector in libnpmdiff

This tiny single use package can live inline with where it's used
Eventually we'll use npm to do this so we don't have to check if color
is enabled
@wraithgar wraithgar requested a review from a team as a code owner April 23, 2024 20:20
@wraithgar wraithgar merged commit 03958c3 into latest Apr 23, 2024
36 checks passed
@wraithgar wraithgar deleted the gar/disparity-colors branch April 23, 2024 20:37
@github-actions github-actions bot mentioned this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants