Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor ls to use output.buffer for json #7542

Merged
merged 1 commit into from
May 17, 2024

Conversation

lukekarrys
Copy link
Contributor

This has no functional difference but matches where
we landed for the rest of the commands.

This has no functional difference but matches where
we landed for the rest of the commands.
@lukekarrys lukekarrys requested a review from a team as a code owner May 17, 2024 17:27
@lukekarrys lukekarrys merged commit 53cda32 into latest May 17, 2024
23 checks passed
@lukekarrys lukekarrys deleted the lk/ls-output-buffer branch May 17, 2024 17:38
@github-actions github-actions bot mentioned this pull request May 17, 2024
@npm-cli-bot
Copy link
Collaborator

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only modules-only no-lock no-cache no-modules no-clean show-version run-script cache-only
peer-deps
no-clean
audit
npm@latest 27.647 ±0.53 10.954 ±0.04 11.930 ±0.08 1.571 ±0.01 1.541 ±0.02 1.299 ±0.02 8.417 ±0.13 1.294 ±0.00 0.141 ±0.00 0.168 ±0.00 14.981 ±0.23 2.141 ±0.07
#7542 30.659 ±4.03 10.827 ±0.07 11.863 ±0.04 1.579 ±0.04 1.604 ±0.04 1.313 ±0.03 8.322 ±0.02 1.319 ±0.02 0.143 ±0.00 0.171 ±0.00 14.905 ±0.06 2.162 ±0.10
app-medium clean lock-only cache-only modules-only no-lock no-cache no-modules no-clean show-version run-script cache-only
peer-deps
no-clean
audit
npm@latest 21.602 ±0.45 8.014 ±0.03 8.942 ±0.04 1.522 ±0.02 1.499 ±0.02 1.408 ±0.00 5.870 ±0.01 1.326 ±0.01 0.140 ±0.00 0.168 ±0.00 9.979 ±0.01 1.996 ±0.06
#7542 22.103 ±0.20 8.077 ±0.03 8.976 ±0.02 1.543 ±0.02 1.506 ±0.01 1.400 ±0.00 5.871 ±0.04 1.322 ±0.02 0.140 ±0.00 0.167 ±0.00 9.876 ±0.06 2.033 ±0.01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants