fix: update notifier to consider engine range #8050
Draft
+15
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
reviewed
Jan 22, 2025
| @@ -83,7 +83,7 @@ const updateNotifier = async (npm, spec = 'latest') => { | |||
| } | |||
|
|
|||
| // while on a beta train, get updates daily | |||
| const duration = spec !== 'latest' ? DAILY : WEEKLY | |||
| const duration = current.prerelease.length ? DAILY : WEEKLY | |||
There was a problem hiding this comment.
This shouldn't have been changed.
There was a problem hiding this comment.
I might be wrong here, but my understanding was since we are using * as spec in new change it will always be !== 'latest' in that case, and what i understood from the existing logic is we are calculating duration as DAILY for pre release version so simplified it to that.
There was a problem hiding this comment.
Oh! I got this patch backwards. You added the prerelease check. This was the right decision.
|
We'll want a new test for the behavior this is guarding against. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing manifest call for fetching npm manifest it was using latest every-time, however fetching
npm@*will still givelatestif it's satisfies the engine range otherwise it will give highest matching version for the current engine range.Pacote.manifest calls internally uses pick-manifest logic to pick the appropriate version of the manifest for the engine range.