Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix npm issue #3380. #2

Closed
wants to merge 2 commits into from
Closed

Fix npm issue #3380. #2

wants to merge 2 commits into from

Commits on Apr 29, 2013

  1. Fix npm issue #3380. 

    Fix npm issue #3380 by changing the following:
- Adapt the regular expression used to match the first
line.
- Create a simple module that can convert shell style variable
declarations: NODE_PATH=./lib:$NODE_PATH to the equivalent batch syntax:
@set=NODE_PATH=./lib:%NODE_PATH%. Furthermore the structure of the generated
shim now looks like this:
@SETLOCAL
<variable declarations>
<original content>
@endlocal
  - Note that the new segments are only added to the file if there were any
variable declarations.

- The generated shell script carries over the captured variable declaration as
is.
- Add some extra tests to validate the behavior.
- Remove some unnecessary white-space in the generated shim.
    @basbossink
    basbossink committed Apr 29, 2013
    Configuration menu
    Copy the full SHA
    86ddb04 View commit details
    Browse the repository at this point in the history

  2. Implemented suggestions by @ForbesLindesay 

    - removed all ;
- moved ./toBatchSyntax.js to bin in ./lib/to-batch-syntax.js
    @basbossink
    basbossink committed Apr 29, 2013
    Configuration menu
    Copy the full SHA
    32fa5bf View commit details
    Browse the repository at this point in the history