-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify the regular expression for shortcut matching #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM! |
nlf
added a commit
that referenced
this pull request
Jan 28, 2021
nlf
force-pushed
the
nlf/simpler-regex
branch
from
January 28, 2021 18:18
c1e6b87
to
133dac3
Compare
nlf
force-pushed
the
nlf/simpler-regex
branch
from
January 28, 2021 18:19
133dac3
to
bede0dc
Compare
Should this be ported to to v2.x, which is still used by npm v6.x? |
nlf
added a commit
that referenced
this pull request
Apr 7, 2021
nlf
added a commit
that referenced
this pull request
Apr 7, 2021
nlf
added a commit
that referenced
this pull request
Apr 7, 2021
PR-URL: #84 Credit: @nlf Close: #84 Reviewed-by: @wraithgar
jeherve
added a commit
to Automattic/jetpack
that referenced
this pull request
May 10, 2021
Closes #19787 For more information: - npm/hosted-git-info#76
This was referenced May 11, 2021
Hi, Was CVE-2021-29063 fixed? Thanks in advance! |
West120912
reviewed
Jul 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
G
This was referenced May 6, 2022
This was referenced Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just removing a bunch of unnecessary complexity from regular expressions where i can