Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify the regular expression for shortcut matching #76

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Jan 28, 2021

just removing a bunch of unnecessary complexity from regular expressions where i can

@isaacs
Copy link
Contributor

isaacs commented Jan 28, 2021

LGTM!

nlf added a commit that referenced this pull request Jan 28, 2021
@nlf nlf force-pushed the nlf/simpler-regex branch from c1e6b87 to 133dac3 Compare January 28, 2021 18:18
@nlf nlf force-pushed the nlf/simpler-regex branch from 133dac3 to bede0dc Compare January 28, 2021 18:19
@nlf nlf closed this in bede0dc Jan 28, 2021
@nlf nlf merged commit bede0dc into latest Jan 28, 2021
@kasicka
Copy link

kasicka commented Apr 6, 2021

Should this be ported to to v2.x, which is still used by npm v6.x?

@OS-WS
Copy link

OS-WS commented Jun 22, 2021

Hi, Was CVE-2021-29063 fixed?

Thanks in advance!

Copy link

@West120912 West120912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants