fix(add): Specify 'en' locale to String.localeCompare (#3)

No test added, since there's nothing in this module that particularly depends on string sorting, but it's a best practice all the same. Re: npm/cli#2829
npm · May 10, 2021 · 7d185c3 · 7d185c3
1 parent 43b1c07
commit 7d185c3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/cache-install-dir.js b/lib/cache-install-dir.js
@@ -12,7 +12,7 @@ const cacheInstallDir = ({ cache, packages }) => {
 
 const getHash = (packages) =>
   crypto.createHash('sha512')
-    .update(packages.sort((a, b) => a.localeCompare(b)).join('\n'))
+    .update(packages.sort((a, b) => a.localeCompare(b, 'en')).join('\n'))
     .digest('hex')
     .slice(0, 16)
 

diff --git a/lib/index.js b/lib/index.js
@@ -143,7 +143,7 @@ const exec = async (opts) => {
       },
     }))
       .map(mani => mani._from)
-      .sort((a, b) => a.localeCompare(b))
+      .sort((a, b) => a.localeCompare(b, 'en'))
 
     // no need to install if already present
     if (add.length) {