This repository has been archived by the owner on Nov 16, 2022. It is now read-only.
Warn if package-lock has newer version than package (even if semver-compliant) #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
Hi, I'm not sure this is change is welcome, but I wanted something like this for my own purposes anyway, so I thought I'll open the PR and see.
While the promise of
package-lock
is that no longer different developers have different versions of the same package and this promise is fulfilled, it doesn't guarantee that version defined inpackage.json
is actually the one that all the developers have ifpackage.json
field uses^
or~
ranges, (which is default behavior when someone doesnpm install _some_package_
)This is of course a known feature of
npm
and the whole point of having ranges. But it's still confusing. In fact, most of the time (by default) the two versions are aligned, until someone nukes package-lock (for example due to merge conflict) and doesnpm install
which regenerates it from scratch_.This PR displays warnings like this in such a scenario:
(I had to update semver to have
semver.minVersion
).Looking forward to comments.