Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: don't use the request signal in the agent (#324)
Following an upgrade from `13.0.1` to `14.0.1` (which included upgrading `@npmcli/agent` from `2.0.0` to `3.0.0`), we've seen strange behaviour: a request works the first time, then immediately times out after that. We're setting a `signal` on each request, which due to changes in `@npmcli/agent` is then also used by the agent for connections. The problem is that the original signal is used for all requests due to agent caching. Once it's been used (i.e. after the first time a request is made), no connections are possible (as they're immediately rejected). This change resolves our issue by removing the signal from the agent. I looked into adding a test, but I don't think it's possible without making real network requests. --------- Co-authored-by: Gar <wraithgar@github.com>
- Loading branch information