This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Split unit tests into a series of smaller files #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't include the test changes from #100, so if that gets merged to master, I'll have to update the corresponding tests here as well. |
|
@revin would you prefer i merge this now or later? s'up to you :) |
|
There's a little bit of effort either way, so I'd vote for sooner rather than later, if it's all the same to you. Go for it. |
|
ok! i'll merge this now. thanks :) |
ashleygwilliams
added a commit
that referenced
this pull request
Jan 26, 2016
Split unit tests into a series of smaller files
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #122, this splits the tests into a bunch of smaller files.
I'm enough of a n00b at Node conventions that I don't know if it's generally accepted to create modules lacking a
module.exports, but doing so keeps the code a little simpler. The test groups themselves were pretty well defined already, so this is mostly just a copy/paste job, plus top-of-filerequirestuff.