Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Update all dependencies 🌴 #86

Closed
wants to merge 1 commit into from

Conversation

greenkeeperio-bot
Copy link
Contributor

Hello 👋

This is the first automated pull requests to help reach the goal of up to date and stable software.
It updates all of the dependencies in the package.json in one go, but from now on you’ll receive pull requests for each dependency update in isolation and in real time.

For updates that satisfy the existing version range you’ll get pull-requests only if it breaks your build.

Example:

-  "underscore": "^1.6.0"
+  "underscore": "^1.7.0"

When an update does not satisfy the existing range you’ll get the pull request right away.

Example:

-  "lodash": "^3.0.0"
+  "lodash": "^4.0.0"

Happy fixing and merging 🌴

@zeke
Copy link
Contributor

zeke commented Jan 5, 2016

Hey @ashleygwilliams I love @greenkeeperio-bot, but it might not be a great fit for marky-markdown in its current state, as a ton of the devDependencies are really just used as test fixtures. Changes to their READMEs are likely to break the tests.

We could work around this by using a different technique to collect fixture data, but maybe there's an easier way.

@janl is there a way to configure greenkeeper to ignore devDependencies?

@zeke
Copy link
Contributor

zeke commented Jan 5, 2016

Hmm I guess we could just lock down the version numbers too.. Would that do it?

@ashleygwilliams
Copy link
Contributor

hey @zeke maybe we should have those as bundled deps then? or just static fixtures?

@zeke
Copy link
Contributor

zeke commented Jan 5, 2016

Using bundleDependencies is not ideal because it will bloat the published package and pass along a bunch of stuff that end-users don't need.

Static fixtures would be the best option, I think. Just need a convenient way to download them. npm-cdn could be handy for fetching all the READMEs.

@ashleygwilliams
Copy link
Contributor

since we don't need to fetch dynamically, i think just cut+paste should be fine? i dont think adding 2-3 md files to the package is too serious. but perhaps i am mistaken?

@zeke
Copy link
Contributor

zeke commented Jan 5, 2016

Yeah cut and paste would totally work! Was just trying to think of a way to automate that effort :)

dont think adding 2-3 md files to the package is too serious

Not worried about markdown files.. I just didn't want to bundle a bunch of entire packages, which is the effect using bundleDependencies would have (I think).

@ashleygwilliams
Copy link
Contributor

yarp-- you wanna PR @zeke ? i want to cut 5.6 tonight, but i could be convinced to wait til tomorrow morning if you wanna sneak this in.

@ashleygwilliams
Copy link
Contributor

ok this is gonna wait til 5.7

@ashleygwilliams ashleygwilliams added this to the 5.7 milestone Jan 6, 2016
@zeke
Copy link
Contributor

zeke commented Jan 6, 2016

@ashleygwilliams I can take care of this, but probably not today. Congrats on shipping 6.0.0!

@janl
Copy link

janl commented Jan 17, 2016

Sorry, I’m only seeing this now; You can use the method described at greenkeeperio/greenkeeper#47 (comment) to have Greenkeeper ignore packages to update.

@ashleygwilliams
Copy link
Contributor

closing per #114

@ashleygwilliams ashleygwilliams deleted the greenkeeper-update-all branch January 19, 2016 15:07
@ashleygwilliams
Copy link
Contributor

the only dep that wasn't eliminated by #114 was standard new pr for that here: #120

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants