fix: correctly increase version for "pre" versions #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The existing tests are correct, I'm not sure what this change is trying to fix.
|
|
Maybe I am wrong, but to me, in #546 on your last comment you mention this |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using this plugin to bump versions every time we release using our CI. It happens for us that we use to create prereleases for QA to test and it can happen that we have several preminors before reaching the final one.
We realised, there were some issues with the version calculation on this specific scenario, so wanted to submit the fix.
Failing test reflecting the issue is the one on line 130, but the fix was also affecting some of the existing tests so I had to modify them also.