-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: preserve pre-release and build parts of a version on coerce (#592) #671
Conversation
…m#592) Introduces the new coerce option `full`, if set, allowing to preserve pre-release and build parts of a version.
7c9a156
to
86535f0
Compare
Should this be using |
Isn't that option have different meaning: to compare without taking prerelease versions into account? I can change it, if it won't cause confusion |
It also includes build part |
No it's the opposite. If true, It seems to make sense to extend this boolean to also include the coercion function. What we want to avoid is adding a new single-use boolean with an extremely generic name like "full". |
Yeah, I meant the opposite (despite what I wrote). I understand the point about name is too generic 👌 |
This is looking really good, heading in the right direction. Just some regex cleanup and an erroneous comment change. The actual implementation in |
It's done, should I squash (rebase) everything into one commit at the end? |
You don't have to, I will squash this when I merge it. |
Thanks for your patience and responses getting this PR ready. This module is one of the most highly downloaded packages on the entire registry and we try to be careful and purposeful when making changes. We're definitely on the right track here and I think this is something that will be able to land soon. |
Okay, linted and tested locally, so everything should be alright. I'm still nervous about option name |
We have been the lack of including There is still the one odd assertion in |
Addressed this in conversation above: #671 (comment) |
What / Why
Introduces the new coerce option
includePrerelease
, if set, allowing to preserve pre-release and build parts of a version.References
Fixes #592
Fixes #357