[Deps] use resolve.isCore instead of is-builtin-module for better data/compat
#99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data and better node compat Fixes #98.
|
If you like, I can add a test by adding a module name to normalize-package-data/test/normalize.js Line 60 in df8ea05 is-builtin-module does not, like worker_threads or v8/tools/arguments?
|
|
A test would be great, thanks. |
|
@aeschright updated with a test! |
|
ping! <3 |
aeschright
reviewed
Feb 4, 2019
|
@aeschright fixed! it was a bad rebase on top of the fix to #98. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98.
Premise: replace
is-builtin-modulewith https://unpkg.com/resolve@1.10.0/lib/core.js (require('resolve').isCore), which both has a much more complete and accurate list of "what is a builtin module" (https://unpkg.com/resolve@1.10.0/lib/core.json vs https://unpkg.com/builtin-modules@3.0.0/builtin-modules.json) and will retain compatibility with older node for essentially forever.