Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

use sh as SHELL for Cygwin/Git-Bash #14

Open
wants to merge 1 commit into
base: latest
Choose a base branch
from

Conversation

gucong3000
Copy link
Contributor

@gucong3000 gucong3000 commented Mar 12, 2018

@zkat
Copy link
Contributor

zkat commented Mar 14, 2018

cc @iarna I believe this would be a breaking change. Usually, we wouldn't support cygwin, but we do try to support git bash/msysgit.

@iarna
Copy link
Contributor

iarna commented May 4, 2018

@zkat This is definitely a bug in npm-lifecycle, imo. We detect msys elsewhere, but not here. As npm/npm#20487 suggests, I think the right solution is to pass in a value computed by npm. But that option should definitely have a default for non-npm and legacy uses.

@gucong3000 gucong3000 force-pushed the patch-1 branch 2 times, most recently from f5e3862 to b353b57 Compare May 4, 2018 06:12
@isaacs
Copy link
Contributor

isaacs commented Jul 17, 2019

I'm finding it challenging to follow the reasoning for this. It looks like it's doing the following:

  • Look up the install location of git in the registry
  • Join that base dir to a bunch of other directories.
  • Make sure all of those are in the env.PATH
  • Join the cmd to that base dir as well.
  • Whenever cmd starts with /, join it to that as well.
  • But only when on a windows system, where the caller has set the isWindowsShell config.

I'm definitely going to need tests to land this.

@isaacs isaacs force-pushed the latest branch 2 times, most recently from 9350636 to 9986486 Compare July 17, 2019 07:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants