Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Expand the list of default ignored files #48

Open
ruyadorno opened this issue Dec 17, 2019 · 3 comments
Open

[FEATURE] Expand the list of default ignored files #48

ruyadorno opened this issue Dec 17, 2019 · 3 comments
Labels
Needs Discussion is pending a discussion semver:major backwards-incompatible breaking changes

Comments

@ruyadorno
Copy link

ruyadorno commented Dec 17, 2019

What / Why

A large population of npm users are concerned about package sizes and with the advent of the file explorer now available on the npmjs.com website we can now see a number of common files that are very intrinsic to the JS community that we could start ignoring from package bundles without too much friction to the larger ecosystem.

Being a breaking change if we are to do it, we should bring this in time for npm@7

How

Expand the current list of ignored files to also ignore by default:

  • .editorconfig
  • .gitattributes
  • .idea (folders and more editors similar configs/store)
  • .travis.yml (and/or more ci services)
  • .yo-rc.json

...and whatever more we think makes sense

Who

  • @npm/cli-team

References

  • n/a
@ruyadorno ruyadorno added Needs Discussion is pending a discussion semver:major backwards-incompatible breaking changes Release 7.x labels Dec 17, 2019
@isaacs
Copy link
Contributor

isaacs commented Jan 2, 2020

This makes sense to me. .github is another good one.

@ruyadorno ruyadorno added the Agenda will be discussed at the Open RFC call label Jan 8, 2020
@darcyclarke darcyclarke removed the Agenda will be discussed at the Open RFC call label Jan 22, 2020
@isaacs
Copy link
Contributor

isaacs commented Jan 26, 2020

So, I wasn't able to attend the RFC meeting where this was discussed, but from the notes, it looks like the consensus reached was "let's look at the packages in the registry and see if anything will break"?

@jaydenseric
Copy link

@isaacs

This makes sense to me. .github is another good one.

Just be aware that some people put images they reference in the readme within the .github directory. If that were not published, there would be 404 images in the published readme displayed in npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Discussion is pending a discussion semver:major backwards-incompatible breaking changes
Projects
None yet
Development

No branches or pull requests

4 participants