Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: @npmcli/redact@2.0.0 #238

Merged
merged 2 commits into from
Apr 30, 2024
Merged

deps: @npmcli/redact@2.0.0 #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a094d64
deps: @npmcli/redact@2.0.0
wraithgar Apr 30, 2024
40db901
chore: fix linting in test files
wraithgar Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"author": "GitHub Inc.",
"license": "ISC",
"dependencies": {
"@npmcli/redact": "^1.1.0",
"@npmcli/redact": "^2.0.0",
"make-fetch-happen": "^13.0.0",
"minipass": "^7.0.2",
"minipass-fetch": "^3.0.0",
Expand Down
6 changes: 3 additions & 3 deletions test/check-response.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ t.test('log x-fetch-attempts header value', async t => {
t.test('log the url fetched', t => {
const headers = new Headers()
const EE = require('events')
headers.get = header => undefined
headers.get = () => undefined
const res = Object.assign({}, mockFetchRes, {
headers,
status: 200,
Expand Down Expand Up @@ -110,7 +110,7 @@ t.test('log the url fetched', t => {
t.test('redact password from log', t => {
const headers = new Headers()
const EE = require('events')
headers.get = header => undefined
headers.get = () => undefined
const res = Object.assign({}, mockFetchRes, {
headers,
status: 200,
Expand Down Expand Up @@ -138,7 +138,7 @@ t.test('redact password from log', t => {
t.test('redact well known token from log', t => {
const headers = new Headers()
const EE = require('events')
headers.get = header => undefined
headers.get = () => undefined
const res = Object.assign({}, mockFetchRes, {
headers,
status: 200,
Expand Down
8 changes: 4 additions & 4 deletions test/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ t.test('OTP error with prompt', async t => {
}
return true
})
.reply((...args) => {
.reply(() => {
if (OTP === '12345') {
return [200, { ok: 'this is fine' }, {}]
} else {
Expand Down Expand Up @@ -171,7 +171,7 @@ t.test('OTP error with prompt, expired OTP in settings', async t => {
}
return true
})
.reply((...args) => {
.reply(() => {
if (OTP === '12345') {
return [200, { ok: 'this is fine' }, {}]
} else {
Expand All @@ -189,7 +189,7 @@ t.test('OTP error with prompt, expired OTP in settings', async t => {
t.test('OTP error with prompt that fails', t => {
tnock(t, OPTS.registry)
.get('/otplease')
.reply((...args) => {
.reply(() => {
return [401, { error: 'otp, please' }, { 'www-authenticate': 'otp' }]
})

Expand All @@ -202,7 +202,7 @@ t.test('OTP error with prompt that fails', t => {
t.test('OTP error with prompt that returns nothing', t => {
tnock(t, OPTS.registry)
.get('/otplease')
.reply((...args) => {
.reply(() => {
return [401, { error: 'otp, please' }, { 'www-authenticate': 'otp' }]
})

Expand Down
Loading