Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hidden dir path clean up corrected #119

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

milaninfy
Copy link
Contributor

@milaninfy milaninfy commented Sep 4, 2024

Path normalization done in #105 resulted in the removal of bin paths that start with . (hidden directory). This PR corrects the path normalization to allow bin paths that start with . (hidden directory).

References

Fixes #116 & npm/cli#7728

@milaninfy milaninfy force-pushed the mm/fix-hidden-dir-path-cleanup branch from 8162098 to bc0069d Compare September 6, 2024 14:43
@milaninfy milaninfy marked this pull request as ready for review September 6, 2024 16:50
@milaninfy milaninfy requested a review from a team as a code owner September 6, 2024 16:50
@wraithgar wraithgar merged commit 962b9e1 into npm:main Sep 17, 2024
25 checks passed
@github-actions github-actions bot mentioned this pull request Sep 17, 2024
wraithgar pushed a commit that referenced this pull request Sep 17, 2024
🤖 I have created a release *beep* *boop*
---


## [5.2.1](v5.2.0...v5.2.1)
(2024-09-17)
### Bug Fixes
*
[`962b9e1`](962b9e1)
[#119](#119) hidden dir path
clean up corrected (#119) (@milaninfy)
### Chores
*
[`e26e236`](e26e236)
[#118](#118) postinstall for
dependabot template-oss PR (@hashtagchris)
*
[`8a7714b`](8a7714b)
[#118](#118) bump
@npmcli/template-oss from 4.23.1 to 4.23.3 (@dependabot[bot])

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Can't exec bin that start with .
2 participants