fix: force gzip flush setting to Z_FULL_FLUSH #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i tested a full matrix of combinations for both
flush
andlevel
(i also did some experimenting withchunkSize
but that yielded nothing meaningful), the combinations that resulted in identical packed results across osx/m1, osx/intel, ubuntu/intel, and arch/intel are as follows:since setting the level to
0
is effectively no compression, that felt like a non-starter, so i went with settingflush
toZ_FULL_FLUSH
. this does yield a bit of a size increase as compared to the default ofZ_NO_FLUSH
(~15% on my test package which is 5.1mb unpacked), but that feels like a pretty reasonable tradeoff to get a bit more consistencyReferences
Related to #76