This repository has been archived by the owner on May 4, 2024. It is now read-only.
support bundleDependencies: true #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm actually not so sure this is a breaking change. Currently, having a non-array in |
What ends up in the parsed output is still an array of names, but we
generate that name from the keys if it's set to true.
Also, avoid the footgun of people not realizing that bundleDependencies
should be an array of names, rather than a {name:version} object.
If bundleDependencies is something other than a boolean or array, it is
removed from the manifest.
isaacs
force-pushed
the
bundledeps-true
branch
from
929bfae to
55382c2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ends up in the parsed output is still an array of names, but we
generate that name from the keys if it's set to true.
Also, avoid the footgun of people not realizing that bundleDependencies
should be an array of names, rather than a {name:versoin} object.
BREAKING CHANGE: raise an error if bundleDependencies is something other
than a boolean or Array.