-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: npm pkg #402
Closed
Closed
RFC: npm pkg #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruyadorno
force-pushed
the
ruyadorno/npm-pkg
branch
from
June 30, 2021 15:11
c6284bd
to
77517ea
Compare
ljharb
reviewed
Jun 30, 2021
This was referenced Jun 30, 2021
Closed
ruyadorno
added a commit
to npm/cli
that referenced
this pull request
Jul 2, 2021
Implements `npm pkg get|set|delete` support. It enables retrieving and modifying values in a `package.json` file of any given project. Included are the implementation based on npm/rfcs#402 along with extensive tests and user documentation. Relates to: npm/rfcs#402 Fixes: npm/statusboard#368
ruyadorno
force-pushed
the
ruyadorno/npm-pkg
branch
from
July 2, 2021 21:58
77517ea
to
dd01b3d
Compare
ruyadorno
added a commit
to npm/cli
that referenced
this pull request
Jul 12, 2021
Implements `npm pkg get|set|delete` support. It enables retrieving and modifying values in a `package.json` file of any given project. Included are the implementation based on npm/rfcs#402 along with extensive tests and user documentation. Relates to: npm/rfcs#402 Fixes: npm/statusboard#368 PR-URL: #3487 Credit: @ruyadorno Close: #3487 Reviewed-by: @wraithgar
Closes: #402
ruyadorno
force-pushed
the
ruyadorno/npm-pkg
branch
from
July 12, 2021 15:22
dd01b3d
to
802e2b5
Compare
ruyadorno
added a commit
to ruyadorno/cli
that referenced
this pull request
Jul 12, 2021
Adds ability to using empty bracket syntax as a shortcut to appending items to the end of an array when using `npm pkg set`, e.g: npm pkg set keywords[]=foo It also adds support to negative indexes, so it's now also possible to retrieve the last item of an array without knowing an exact index, e.g: npm pkg get keywords[-1] Relates to: npm/rfcs#402
ruyadorno
added a commit
to ruyadorno/cli
that referenced
this pull request
Jul 12, 2021
Adds ability to using empty bracket syntax as a shortcut to appending items to the end of an array when using `npm pkg set`, e.g: npm pkg set keywords[]=foo Relates to: npm/rfcs#402
ruyadorno
added a commit
to ruyadorno/cli
that referenced
this pull request
Jul 13, 2021
Adds ability to using empty bracket syntax as a shortcut to appending items to the end of an array when using `npm pkg set`, e.g: npm pkg set keywords[]=foo Relates to: npm/rfcs#402
ruyadorno
added a commit
to ruyadorno/cli
that referenced
this pull request
Jul 13, 2021
Adds ability to using empty bracket syntax as a shortcut to appending items to the end of an array when using `npm pkg set`, e.g: npm pkg set keywords[]=foo Relates to: npm/rfcs#402
ruyadorno
added a commit
to ruyadorno/cli
that referenced
this pull request
Jul 13, 2021
Adds ability to using empty bracket syntax as a shortcut to appending items to the end of an array when using `npm pkg set`, e.g: npm pkg set keywords[]=foo Relates to: npm/rfcs#402
ruyadorno
added a commit
to ruyadorno/cli
that referenced
this pull request
Jul 13, 2021
Adds ability to using empty bracket syntax as a shortcut to appending items to the end of an array when using `npm pkg set`, e.g: npm pkg set keywords[]=foo Relates to: npm/rfcs#402
ruyadorno
added a commit
to ruyadorno/cli
that referenced
this pull request
Jul 13, 2021
Adds ability to using empty bracket syntax as a shortcut to appending items to the end of an array when using `npm pkg set`, e.g: npm pkg set keywords[]=foo Relates to: npm/rfcs#402
ruyadorno
added a commit
to ruyadorno/cli
that referenced
this pull request
Jul 13, 2021
Adds ability to using empty bracket syntax as a shortcut to appending items to the end of an array when using `npm pkg set`, e.g: npm pkg set keywords[]=foo Relates to: npm/rfcs#402
ruyadorno
added a commit
to ruyadorno/cli
that referenced
this pull request
Jul 13, 2021
Adds ability to using empty bracket syntax as a shortcut to appending items to the end of an array when using `npm pkg set`, e.g: npm pkg set keywords[]=foo Relates to: npm/rfcs#402
ruyadorno
added a commit
to ruyadorno/cli
that referenced
this pull request
Jul 13, 2021
Adds ability to using empty bracket syntax as a shortcut to appending items to the end of an array when using `npm pkg set`, e.g: npm pkg set keywords[]=foo Relates to: npm/rfcs#402
ruyadorno
added a commit
to ruyadorno/cli
that referenced
this pull request
Jul 14, 2021
Adds ability to using empty bracket syntax as a shortcut to appending items to the end of an array when using `npm pkg set`, e.g: npm pkg set keywords[]=foo Relates to: npm/rfcs#402
ruyadorno
added a commit
to npm/cli
that referenced
this pull request
Jul 15, 2021
Adds ability to using empty bracket syntax as a shortcut to appending items to the end of an array when using `npm pkg set`, e.g: npm pkg set keywords[]=foo Relates to: npm/rfcs#402 PR-URL: #3539 Credit: @ruyadorno Close: #3539 Reviewed-by: @darcyclarke, @ljharb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rendered RFC