Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] v3.0.1 has a breaking change #72

Closed
1 task done
ljharb opened this issue May 13, 2022 · 1 comment
Closed
1 task done

[BUG] v3.0.1 has a breaking change #72

ljharb opened this issue May 13, 2022 · 1 comment
Labels
Needs Triage needs an initial review

Comments

@ljharb
Copy link
Contributor

ljharb commented May 13, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

v3.0.1 includes node-gyp 9 in #52, but this was a breaking change, because node-gyp 9 requires node 12.22, and run-script v3.0.0 only require node v12.13.

Can that update be reverted in a v3.0.3?

Expected Behavior

No response

Steps To Reproduce

No response

Environment

No response
@ljharb ljharb added the Needs Triage needs an initial review label May 13, 2022
ljharb added a commit to ljharb/ls-engines that referenced this issue May 13, 2022
@ljharb
[Fix] peg dependency versions due to breaking change in `@npmcli/run-…
317e754 
…script`

See npm/run-script#72
@lukekarrys
Copy link
Contributor

Closed by #73

This was referenced May 25, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Triage needs an initial review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @lukekarrys