Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify regex #17

Merged
merged 2 commits into from
Jan 27, 2021
Merged

simplify regex #17

merged 2 commits into from
Jan 27, 2021

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Jan 19, 2021

this simplifies the strict mode regular expression because it was doing way more work than it needed to.

also updated the standard and standard-version dev dependencies, fixed a linting error that the new standard complains about, and updated the package-lock.json for npm 7 and to resolve any vulnerabilities that were found in nested dependencies.

References

@nlf nlf requested a review from a team as a code owner January 19, 2021 21:47
@darcyclarke darcyclarke added this to the OSS - Sprint 23 milestone Jan 26, 2021
@darcyclarke
Copy link

@nlf when you pull this in - most likely Wednesday/Thursday - can we also update deps before cutting a release?

@nlf nlf closed this in 2083289 Jan 27, 2021
@nlf nlf merged commit 2083289 into latest Jan 27, 2021
@nlf nlf deleted the nlf/fix-regex branch January 27, 2021 19:35
@G-Rath
Copy link

G-Rath commented Apr 14, 2021

@nlf @ruyadorno I've made #20 backporting this to v7

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants