Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move from symbols to private methods #74

Merged
merged 1 commit into from
Apr 3, 2023
Merged

fix: move from symbols to private methods #74

merged 1 commit into from
Apr 3, 2023

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Apr 3, 2023

Also reverted an Object.create(null) to {}

@wraithgar wraithgar requested a review from a team as a code owner April 3, 2023 14:46
@wraithgar wraithgar requested a review from fritzy April 3, 2023 14:46
@wraithgar
Copy link
Member Author

cc @H4ad

@H4ad
Copy link
Contributor

H4ad commented Apr 3, 2023

For performance, the fastest way of creating a object is like this:

https://github.com/RafaelGSS/nodejs-bench-operations/blob/main/bench/object-creation.js#L5-L6

Ref: https://github.com/RafaelGSS/nodejs-bench-operations/blob/main/RESULTS-v19.md#object-creation

But is not that critical so I don't think is a problem in any case.

@wraithgar
Copy link
Member Author

Yeah again we need to balance performance with developer experience. This module is called maybe 20,000 times even on the largest benchmark install. Performance is important but it is not the bottleneck of a typical install.

@wraithgar wraithgar merged commit 8e80eca into main Apr 3, 2023
@wraithgar wraithgar deleted the gar/cleanup branch April 3, 2023 21:52
@github-actions github-actions bot mentioned this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants