Skip to content

Commit

Permalink
fix: always lint all js-ish extensions
Browse files Browse the repository at this point in the history
  • Loading branch information
lukekarrys committed Nov 15, 2023
1 parent 37e9e0e commit 3fca74f
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion lib/content/package-json.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"author": "GitHub Inc.",
"files": {{{ json distPaths }}},
"scripts": {
"lint": "{{#if eslint}}eslint \"**/*.js\"{{else}}echo linting disabled{{/if}}",
"lint": "{{#if eslint}}eslint \"**/*.{js,cjs,ts,mjs,jsx,tsx}\"{{else}}echo linting disabled{{/if}}",
"postlint": "template-oss-check",
"template-oss-apply": "template-oss-apply --force",
"lintfix": "{{ localNpmPath }} run lint -- --fix",
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"template-oss-release-manager": "bin/release-manager.js"
},
"scripts": {
"lint": "eslint \"**/*.js\"",
"lint": "eslint \"**/*.{js,cjs,ts,mjs,jsx,tsx}\"",
"lintfix": "npm run lint -- --fix",
"posttest": "npm run lint",
"snap": "tap",
Expand Down
12 changes: 6 additions & 6 deletions tap-snapshots/test/apply/source-snapshots.js.test.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -1632,7 +1632,7 @@ package.json
"name": "testpkg",
"version": "1.0.0",
"scripts": {
"lint": "eslint /"**/*.js/"",
"lint": "eslint /"**/*.{js,cjs,ts,mjs,jsx,tsx}/"",
"postlint": "template-oss-check",
"template-oss-apply": "template-oss-apply --force",
"lintfix": "npm run lint -- --fix",
Expand Down Expand Up @@ -3716,7 +3716,7 @@ package.json
"workspaces/b"
],
"scripts": {
"lint": "eslint /"**/*.js/"",
"lint": "eslint /"**/*.{js,cjs,ts,mjs,jsx,tsx}/"",
"postlint": "template-oss-check",
"template-oss-apply": "template-oss-apply --force",
"lintfix": "npm run lint -- --fix",
Expand Down Expand Up @@ -3863,7 +3863,7 @@ workspaces/a/package.json
"name": "a",
"version": "1.0.0",
"scripts": {
"lint": "eslint /"**/*.js/"",
"lint": "eslint /"**/*.{js,cjs,ts,mjs,jsx,tsx}/"",
"postlint": "template-oss-check",
"template-oss-apply": "template-oss-apply --force",
"lintfix": "npm run lint -- --fix",
Expand Down Expand Up @@ -3943,7 +3943,7 @@ workspaces/b/package.json
"name": "b",
"version": "1.0.0",
"scripts": {
"lint": "eslint /"**/*.js/"",
"lint": "eslint /"**/*.{js,cjs,ts,mjs,jsx,tsx}/"",
"postlint": "template-oss-check",
"template-oss-apply": "template-oss-apply --force",
"lintfix": "npm run lint -- --fix",
Expand Down Expand Up @@ -5555,7 +5555,7 @@ workspaces/a/package.json
"name": "a",
"version": "1.0.0",
"scripts": {
"lint": "eslint /"**/*.js/"",
"lint": "eslint /"**/*.{js,cjs,ts,mjs,jsx,tsx}/"",
"postlint": "template-oss-check",
"template-oss-apply": "template-oss-apply --force",
"lintfix": "npm run lint -- --fix",
Expand Down Expand Up @@ -5635,7 +5635,7 @@ workspaces/b/package.json
"name": "b",
"version": "1.0.0",
"scripts": {
"lint": "eslint /"**/*.js/"",
"lint": "eslint /"**/*.{js,cjs,ts,mjs,jsx,tsx}/"",
"postlint": "template-oss-check",
"template-oss-apply": "template-oss-apply --force",
"lintfix": "npm run lint -- --fix",
Expand Down
8 changes: 4 additions & 4 deletions tap-snapshots/test/check/snapshots.js.test.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ The module file package.json needs to be updated:
"lib/"
]
"scripts" is missing, expected {
"lint": "eslint /"**/*.js/"",
"lint": "eslint /"**/*.{js,cjs,ts,mjs,jsx,tsx}/"",
"postlint": "template-oss-check",
"template-oss-apply": "template-oss-apply --force",
"lintfix": "npm run lint -- --fix",
Expand Down Expand Up @@ -325,7 +325,7 @@ The module file package.json needs to be updated:
"lib/"
]
"scripts" is missing, expected {
"lint": "eslint /"**/*.js/"",
"lint": "eslint /"**/*.{js,cjs,ts,mjs,jsx,tsx}/"",
"postlint": "template-oss-check",
"template-oss-apply": "template-oss-apply --force",
"lintfix": "npm run lint -- --fix",
Expand Down Expand Up @@ -401,7 +401,7 @@ The module file package.json needs to be updated:
"lib/"
]
"scripts" is missing, expected {
"lint": "eslint /"**/*.js/"",
"lint": "eslint /"**/*.{js,cjs,ts,mjs,jsx,tsx}/"",
"postlint": "template-oss-check",
"template-oss-apply": "template-oss-apply --force",
"lintfix": "npm run lint -- --fix",
Expand Down Expand Up @@ -470,7 +470,7 @@ The module file package.json needs to be updated:
"lib/"
]
"scripts" is missing, expected {
"lint": "eslint /"**/*.js/"",
"lint": "eslint /"**/*.{js,cjs,ts,mjs,jsx,tsx}/"",
"postlint": "template-oss-check",
"template-oss-apply": "template-oss-apply --force",
"lintfix": "npm run lint -- --fix",
Expand Down
2 changes: 1 addition & 1 deletion workspace/test-workspace/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"private": true,
"scripts": {
"test": "tap",
"lint": "eslint \"**/*.js\"",
"lint": "eslint \"**/*.{js,cjs,ts,mjs,jsx,tsx}\"",
"postlint": "template-oss-check",
"template-oss-apply": "template-oss-apply --force",
"lintfix": "npm run lint -- --fix",
Expand Down

0 comments on commit 3fca74f

Please sign in to comment.