feat: make template-oss postinstall commit a breaking change for majors #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
force-pushed
the
lk/template-oss-postinstall
branch
from
2ff4c06 to
63780f2
Compare
This was referenced Sep 2, 2022
|
One thing this assumes is that I think this is a safe assumption since The alternative is a well known commit footer message (eg |
wraithgar
reviewed
Sep 8, 2022
lukekarrys
force-pushed
the
main
branch
23 times, most recently
from
069febb to
7842f89
Compare
lukekarrys
force-pushed
the
main
branch
11 times, most recently
from
0ff0641 to
3640080
Compare
When we ship things like `engines` changes we will release a semver major update to template-oss, and the resulting dependabot PRs will get a `feat!` commit to indicate that they will all need major releases as well. This doesn't assume anything about the contents of the breaking change, but will instead set the correct conventional commit type and fail the PR so that it can be followed up manually.
lukekarrys
force-pushed
the
lk/template-oss-postinstall
branch
from
7c191b3 to
88ad28d
Compare
wraithgar
approved these changes
Sep 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we ship
engineschanges we will release a semver major updateto template-oss, and the resulting dependabot PRs will get a
feat!commit to indicate that they will all need major releases as well.
This also updates the workflow to attempt to commit a subset of the
applied changes, without the workflows. The workflow will still fail, if
any changes were not committed but this allows us to have the proper
conventional commit message in the git history that we can amend when
fixing these PRs manually.