Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set ci versions from engines #356

Merged
merged 2 commits into from
Sep 14, 2023
Merged

feat: set ci versions from engines #356

merged 2 commits into from
Sep 14, 2023

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Sep 14, 2023 •
edited
Loading

Fixes #340

@lukekarrys
Copy link
Contributor Author

failures here are from exit code issues with node 20

@lukekarrys lukekarrys marked this pull request as ready for review September 14, 2023 17:36
@lukekarrys lukekarrys requested a review from a team as a code owner September 14, 2023 17:36
@lukekarrys lukekarrys merged commit 339c780 into main Sep 14, 2023
@lukekarrys lukekarrys deleted the lk/ci-from-engines branch September 14, 2023 19:16
@github-actions github-actions bot mentioned this pull request Sep 14, 2023
Merged
This was referenced Jun 20, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test in Node 20 by default
2 participants
@lukekarrys @wraithgar