Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: give release integration workflow correct permissions and secrets #384

Merged
merged 1 commit into from
Nov 28, 2023
Merged

fix: give release integration workflow correct permissions and secrets #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/release-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ on:
required: true
type: string
description: 'A json array of releases. Required fields: publish: tagName, publishTag. publish check: pkgName, version'
secrets:
PUBLISH_TOKEN:
required: true

jobs:
publish:
Expand All @@ -24,7 +27,6 @@ jobs:
run:
shell: bash
permissions:
deployments: write
id-token: write
steps:
- name: Checkout
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,10 @@ jobs:
name: Release Integration
if: needs.release.outputs.releases
uses: ./.github/workflows/release-integration.yml
permissions:
id-token: write
secrets:
PUBLISH_TOKEN: ${{ secrets.PUBLISH_TOKEN }}
with:
releases: ${{ needs.release.outputs.releases }}

Expand Down
1 change: 0 additions & 1 deletion lib/content/_job-release-integration-yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ defaults:
shell: bash
{{#if publish}}
permissions:
deployments: write
id-token: write
{{/if}}
steps:
Expand Down
5 changes: 5 additions & 0 deletions lib/content/release-integration-yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ on:
required: true
type: string
description: 'A json array of releases. Required fields: publish: tagName, publishTag. publish check: pkgName, version'
{{#if publish}}
secrets:
PUBLISH_TOKEN:
required: true
{{/if}}

jobs:
publish:
Expand Down
6 changes: 6 additions & 0 deletions lib/content/release-yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,12 @@ jobs:
name: Release Integration
if: needs.release.outputs.releases
uses: ./.github/workflows/release-integration.yml
{{#if publish}}
permissions:
id-token: write
secrets:
PUBLISH_TOKEN: $\{{ secrets.PUBLISH_TOKEN }}
{{/if}}
with:
releases: $\{{ needs.release.outputs.releases }}

Expand Down