Skip to content

Commit

Permalink
get_MMIO_BAR_base_address inconsistency
Browse files Browse the repository at this point in the history
Found that is_ba_invalid is not updated within 'align_bits' conditional
causing an exception when a vaild base address is found

Signed-off-by: brentholtsclaw <brent.holtsclaw@intel.com>
  • Loading branch information
BrentHoltsclaw authored and npmitche committed Sep 30, 2024
1 parent 78e603d commit 30a2f61
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions chipsec/hal/mmio.py
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@ def get_MMIO_BAR_base_address(self, bar_name: str, bus: Optional[int] = None) ->
limit += ((0x1 << int(bar['align_bits'])) - 1)
limit += start
size = limit - base
is_ba_invalid = base == 0 or is_all_ones(base, size)
else:
size = bar['size'] if ('size' in bar) else DEFAULT_MMIO_BAR_SIZE

Expand Down

0 comments on commit 30a2f61

Please sign in to comment.