Skip to content
This repository has been archived by the owner on Mar 26, 2021. It is now read-only.

Expand tests to modern WordPress versions and PHP versions #46

Merged
merged 5 commits into from
Apr 16, 2018
Merged

Expand tests to modern WordPress versions and PHP versions #46

merged 5 commits into from
Apr 16, 2018

Commits on Mar 20, 2018

  1. Update from testing php 5.3-5.5 to 5.6-7.2

    @benlk
    benlk committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    1ac7728 View commit details
    Browse the repository at this point in the history

  2. Update tests from Wordpress 3.8.14-4.5.5 to 3.8-4.9, to use latest pa… 

    …tch releases
    @benlk
    benlk committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    649f683 View commit details
    Browse the repository at this point in the history

  3. Drastically reduce the number of builds that are made with Travis 

    Based on research in https://github.com/npr/pmp-php-sdk/issues/36,
Travis CI runs tests using the following PHPUnit versions:

- PHP 5.6: PHPUnit 5.7.23
- PHP 7: PHPUnit 6.4.3
- PHP 7.1: PHPUnit 6.4.3
- PHP 7.2: PHPUnit 7.0.2

This commit reduces the number of tests that are run by more than
two thirds. Before, we were running 4 different PHP versions and
11 diffferent WordPress versions. Many of those combinations were
incompatible, for different reasons:

1. There are PHP warnings about deprecated PHP-4-style
   constructors.
2. Requires PHPUnit 5 because PHPUnit 6 support was not
   included until WordPress 4.7.
3. Unless there's been an update since
   [this trac thread](https://core.trac.wordpress.org/ticket/39822),
   WordPress tests still assume PHPUnit 6, and Travis runs PHP 7.2
   tests with PHPUnit 7

| phpunit | 5.7 | 6.4 | 6.4 | 7.0 |                 |                  |
| php     | 5.6 | 7.0 | 7.1 | 7.2 |                 |                  |
| WP      |     |     |     |     | wp release year | then-current php |
|---------|-----|-----|-----|-----|-----------------|------------------|
| 3.8     |     | 1   | 1   | 1   | 2013            |                  |
| 3.9     |     | 1   | 1   | 1   | 2014            | 5.5              |
| 4.0     |     | 1   | 1   | 1   | 2014            | 5.5              |
| 4.1     |     | 1   | 1   | 1   | 2014            | 5.5              |
| 4.2     |     | 2   | 2   | 2   | 2015            | 5.6              |
| 4.3     |     | 2   | 2   | 2   | 2015            | 5.6              |
| 4.4     |     | 2   | 2   | 2   | 2015            | 7.0              |
| 4.5     |     | 2   | 2   | 2   | 2016            | 7.0              |
| 4.6     |     | 2   | 2   | 2   | 2016            | 7.0              |
| 4.7     |     |     |     | 3   | 2016            | 7.1              |
| 4.8     |     |     |     | 3   | 2017            | 7.1              |
| 4.9     |     |     |     | 3   | 2017            | 7.2              |

Accordingly, this commit removes PHP 7.2 from tests, and replaces the
separate lists of PHP and WordPress versions with one list of selected
PHP and WordPress versions.
    @benlk
    benlk committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    09d72a8 View commit details
    Browse the repository at this point in the history

  4. Reduce number of builds by removing WP 4.7 in PHP > 7 

    Updated version of the table in 09d72a8:

Based on research in npr/pmp-php-sdk#36,
Travis CI runs tests using the following PHPUnit versions:

- PHP 5.6: PHPUnit 5.7.23
- PHP 7: PHPUnit 6.4.3
- PHP 7.1: PHPUnit 6.4.3
- PHP 7.2: PHPUnit 7.0.2

Reasons that given versions of WordPress have tests incompatible
with travis-ci.org:

1. There are PHP warnings about deprecated PHP-4-style
   constructors.
2. Requires PHPUnit 5 because PHPUnit 6 support was not
   included until WordPress 4.7.
3. Unless there's been an update since
   [this trac thread](https://core.trac.wordpress.org/ticket/39822),
   WordPress tests still assume PHPUnit 6, and Travis runs PHP 7.2
   tests with PHPUnit 7

| phpunit | 5.7 | 6.4 | 6.4 | 7.0 |                 |                  |
| php     | 5.6 | 7.0 | 7.1 | 7.2 |                 |                  |
| WP      |     |     |     |     | wp release year | then-current php |
|---------|-----|-----|-----|-----|-----------------|------------------|
| 3.8     |     | 1   | 1   | 1   | 2013            |                  |
| 3.9     |     | 1   | 1   | 1   | 2014            | 5.5              |
| 4.0     |     | 1   | 1   | 1   | 2014            | 5.5              |
| 4.1     |     | 1   | 1   | 1   | 2014            | 5.5              |
| 4.2     |     | 2   | 2   | 2   | 2015            | 5.6              |
| 4.3     |     | 2   | 2   | 2   | 2015            | 5.6              |
| 4.4     |     | 2   | 2   | 2   | 2015            | 7.0              |
| 4.5     |     | 2   | 2   | 2   | 2016            | 7.0              |
| 4.6     |     | 2   | 2   | 2   | 2016            | 7.0              |
| 4.7     |     | 2   | 2   | 2   | 2016            | 7.1              |
| 4.8     |     |     |     | 3   | 2017            | 7.1              |
| 4.9     |     |     |     | 3   | 2017            | 7.2              |
    @benlk
    benlk committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    0130703 View commit details
    Browse the repository at this point in the history

  5. Comment the include matrix on PHPUnit versions

    @benlk
    benlk committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    899e38d View commit details
    Browse the repository at this point in the history