Fix #803 a quiksyncdef error from DYNJAWS in BEAMnrc GUI #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtownson
force-pushed
the
fix-beamgui-quiksyncdef
branch
from
d95558a
to
fd7788a
Compare
|
That was quick! Thank you @rtownson. |
ftessier
approved these changes
Dec 2, 2021
blakewalters
approved these changes
Feb 25, 2022
Fix a GUI error that occurred in DYNJAWS jaw definitions when clicking the button to calculate the jaw settings from the field size and SSD. The button triggered a function that was duplicated with the same name in SYNCJAWS, leading to the error. As the fix, the syncjaws version of the function has been renamed. This bug has existed since SYNCJAWS was added to the GUI.
ftessier
force-pushed
the
fix-beamgui-quiksyncdef
branch
from
fd7788a
to
4cd46d1
Compare
mainegra
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #803 a GUI error that occurred in DYNJAWS jaw definitions when clicking
the button to calculate the jaw settings from the field size and SSD.
The button triggered a function that was duplicated with the same name
in SYNCJAWS, leading to the error. As the fix, the syncjaws version of
the function has been renamed. This bug has existed since SYNCJAWS was
added to the GUI.