bluetooth: fast_pair: separate subsequent pairing feature into Kconfig #16287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapi-no
requested review from
alstrzebonski,
MarekPieta,
KAGA164,
alwa-nordic,
jori-nordic and
carlescufi
as code owners
github-actions
bot
added
doc-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
kapi-no
force-pushed
the
fast_pair_subsequent_pairing
branch
from
87621cb
to
eab96fb
Compare
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
zycz
approved these changes
Jul 1, 2024
| help | ||
| Enable support for the Subsequent Pairing feature. Subsequent pairing | ||
| is the later pairing between the previously initial-paired device and | ||
| the other phone where the same Google Account is logged-in. |
MarekPieta
requested changes
Jul 2, 2024
kapi-no
force-pushed
the
fast_pair_subsequent_pairing
branch
6 times, most recently
from
be985bd
to
ded5d24
Compare
MarekPieta
removed
the
changelog-entry-required
|
@MarekPieta, please do not remove the changelog label. Before I can finalize this PR, I will need to create a changelog entry (once the release process is completed). |
MarekPieta
approved these changes
Jul 2, 2024
kapi-no
force-pushed
the
fast_pair_subsequent_pairing
branch
from
ded5d24
to
c045969
Compare
github-actions
bot
added
the
changelog-entry-required
|
Rebased only. No file diff has changed. |
kapi-no
force-pushed
the
fast_pair_subsequent_pairing
branch
from
c045969
to
fd37c4c
Compare
github-actions
bot
removed
the
changelog-entry-required
|
The last force-push add changelog entries for this modification. |
kapi-no
force-pushed
the
fast_pair_subsequent_pairing
branch
from
fd37c4c
to
a61c946
Compare
|
The last force-push adds a small fix for the build issue after I moved the validation logic to a different function following the review suggestion. |
MarekPieta
approved these changes
Jul 10, 2024
annwoj
reviewed
Jul 10, 2024
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
annwoj
reviewed
Jul 10, 2024
kapi-no
force-pushed
the
fast_pair_subsequent_pairing
branch
from
a61c946
to
ad2fae8
Compare
annwoj
approved these changes
Jul 11, 2024
Improved the description of the bt_fast_pair_set_pairing_mode API function in the "Setting up Bluetooth LE advertising" step of the Fast Pair integration guide. Signed-off-by: Kamil Piszczek <Kamil.Piszczek@nordicsemi.no>
Improved the description of the enabling policy for a few Kconfig entries in the Fast Pair service documentation. Signed-off-by: Kamil Piszczek <Kamil.Piszczek@nordicsemi.no>
Added a new Kconfig option for the Fast Pair Subsequent Pairing feature. As a result, this previously supported feature is now configurable and can be disabled for the locator tag use case, which does not support subsequent pairing. Aligned the Fast Pair Advertising Provider with the new Kconfig option for the Fast Pair service, which controls the Subsequent Pairing feature. Removed the unavailable API call of the Fast Pair Advertising Provider from the Fast Pair Locator Tag sample. Ref: NCSDK-27955 Signed-off-by: Kamil Piszczek <Kamil.Piszczek@nordicsemi.no>
kapi-no
force-pushed
the
fast_pair_subsequent_pairing
branch
from
ad2fae8
to
133f1c1
Compare
|
Rebased only due to the failing BLE CI. No file diff has changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new Kconfig option for the Fast Pair Subsequent Pairing feature. As a result, this previously supported feature is now configurable and can be disabled for the locator tag use case, which does not support subsequent pairing.
Aligned the Fast Pair Advertising Provider with the new Kconfig option for the Fast Pair service, which controls the Subsequent Pairing feature.
Removed the unavailable API call of the Fast Pair Advertising Provider from the Fast Pair Locator Tag sample.
Ref: NCSDK-27955