snippets: Added snippet for Matter power consumption measurements #20072

kkasperczyk-no · 2025-01-24T13:20:10Z

Matter requires some extra configuration for the power consumption measurements that are automatized. This change introduces snippet that simplifies it and adds dedicated variant in the sample.ymls.

NordicBuilder · 2025-01-24T13:22:37Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: b1fd34539090a3b3aa65fe6bf0f20b1ff90a74e3

more details

sdk-nrf:

PR head: b1fd34539090a3b3aa65fe6bf0f20b1ff90a74e3
merge base: a14efda70dbef70e0a2a6dc27f66a5f63f7fc2a6
target head (main): 8a0d4647d6c16dcd88e0b5b489c2033bd1e97c99
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (9)

CODEOWNERS
samples
│  ├── matter
│  │  ├── lock
│  │  │  │ sample.yaml
│  │  ├── smoke_co_alarm
│  │  │  │ sample.yaml
│  │  ├── window_covering
│  │  │  │ sample.yaml
scripts
│  │ quarantine_integration.yaml
snippets
│  ├── matter-power-consumption-tests
│  │  ├── boards
│  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  ├── power_consumption_tests.conf
│  │  │ snippet.yml

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 115
✅ Integration tests
- ✅ test-fw-nrfconnect-chip

Disabled integration tests

- desktop52_verification
- doc-internal
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_mosh
- test-fw-nrfconnect-nrf-iot_positioning
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-ps
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread
- test-fw-nrfconnect-zigbee
- test-low-level
- test-sdk-audio
- test-sdk-dfu
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-sidewalk
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

nordicjm · 2025-01-24T13:25:23Z

snippets/matter-power-consumption-tests/boards/nrf54l15dk_nrf54l15_cpuapp.conf

+# Disable LEDs that lead to the current leakages
+CONFIG_NCS_SAMPLE_MATTER_LEDS=n
+
+# Disable watchdog that increases the sleep current
+CONFIG_NCS_SAMPLE_MATTER_WATCHDOG=n
+
+# Increase MPSL calibration period to prevent too often CPU wake-ups.
+CONFIG_MPSL_CALIBRATION_PERIOD=60000


why does this need a specific kconfig fragment for the board, why can't it go in the normal snippet .conf?

Because, the nRF54L15 needs few additional tweaks to lower power consumption. On other platforms this is not required (this particular Kconfig option is even not used).

so disabling it isn't a problem then, that way there is a snippet that works for all boards including customer boards, whereas right now this works for no nrf54l* customer boards

This is not targeted for the customers use, and we also do not mention how to use it in the documentation. This is added for the QA to avoid handling multiple configurations in their Test Automation System.

This works on all boards, but we don't want to use it with all boards, because this is not required. Only nRF54L15 DK (not SoC) has problems with LEDs current leakage, so I don't see a reason to disable it for other/customer boards as well. Similarly, we configure nrf dks in samples' boards directory and this does not apply to the customers' boards, so I think we are not doing anything different here.

Just to be clear, as maybe I haven't put it explicitly. Disabling this modules is not something we would like to do, ideally we would like to keep it enabled. Unfortunately, the nRF54L15 DK requires this sort of "workaround", so we don't want to put workaround, where it is not required.

Here is the justification: https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/protocols/matter/getting_started/low_power_configuration.html#disable_leds_module

samples/matter/smoke_co_alarm/sample.yaml

samples/matter/light_switch/sample.yaml

NordicBuilder · 2025-01-24T13:42:15Z

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

doublemis1

LGTM

ArekBalysNordic

I guess you should add the new snippet to codeowners and assign the ncs-matter to it.

doublemis1 · 2025-01-24T14:10:15Z

@kkasperczyk-no, forgot to mention, can you look at the integration_quarantine.yaml in the scripts dir?
Maybe we can add these configuration to the integration quarantine, instead of on sample (on all platforms) e.g. door lock

Matter requires some extra configuration for the power consumption measurements that are automatized. This change introduces snippet that simplifies it and adds dedicated variant in the sample.ymls. Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no>

kkasperczyk-no · 2025-01-27T10:24:07Z

@kkasperczyk-no, forgot to mention, can you look at the integration_quarantine.yaml in the scripts dir? Maybe we can add these configuration to the integration quarantine, instead of on sample (on all platforms) e.g. door lock

@doublemis1 done, please re-check

ArekBalysNordic · 2025-01-27T14:16:08Z

snippets/matter-power-consumption-tests/snippet.yml

+  nrf54l15dk/nrf54l15/cpuapp:
+    append:
+      EXTRA_CONF_FILE: boards/nrf54l15dk_nrf54l15_cpuapp.conf
+  nrf54l15dk/nrf54l10/cpuapp:
+    append:
+      EXTRA_CONF_FILE: boards/nrf54l15dk_nrf54l10_cpuapp.conf


Actually, we can merge those two to all DKs dedicated for nRF54L15 and don't have the additional nrf54l15dk_nrf54l10_cpuapp.conf file to maintain:

Suggested change

nrf54l15dk/nrf54l15/cpuapp:

append:

EXTRA_CONF_FILE: boards/nrf54l15dk_nrf54l15_cpuapp.conf

nrf54l15dk/nrf54l10/cpuapp:

append:

EXTRA_CONF_FILE: boards/nrf54l15dk_nrf54l10_cpuapp.conf

boards:

/nrf54l15dk.*/:

append:

EXTRA_DTC_OVERLAY_FILE: boards/nrf54l15dk_nrf54l15_cpuapp.overlay

I think we should change the overlay file name then? to something generic for all nrf54l15dk builds?

kkasperczyk-no requested review from a team as code owners January 24, 2025 13:20

github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 24, 2025

kkasperczyk-no force-pushed the low_power_config branch from 0a266fa to f697e7b Compare January 24, 2025 13:22

maciejbaczmanski approved these changes Jan 24, 2025

View reviewed changes

kkasperczyk-no force-pushed the low_power_config branch from f697e7b to ac42c61 Compare January 24, 2025 13:24

nordicjm reviewed Jan 24, 2025

View reviewed changes

doublemis1 reviewed Jan 24, 2025

View reviewed changes

samples/matter/smoke_co_alarm/sample.yaml Outdated Show resolved Hide resolved

doublemis1 reviewed Jan 24, 2025

View reviewed changes

samples/matter/light_switch/sample.yaml Outdated Show resolved Hide resolved

kkasperczyk-no force-pushed the low_power_config branch from ac42c61 to 6b4c40f Compare January 24, 2025 13:50

doublemis1 approved these changes Jan 24, 2025

View reviewed changes

ArekBalysNordic reviewed Jan 24, 2025

View reviewed changes

kkasperczyk-no force-pushed the low_power_config branch from 6b4c40f to d233134 Compare January 24, 2025 14:04

kkasperczyk-no requested a review from a team as a code owner January 24, 2025 14:04

github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 24, 2025

kkasperczyk-no force-pushed the low_power_config branch from d233134 to b1fd345 Compare January 27, 2025 10:23

kkasperczyk-no requested a review from a team as a code owner January 27, 2025 10:23

doublemis1 approved these changes Jan 27, 2025

View reviewed changes

ArekBalysNordic reviewed Jan 27, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

snippets: Added snippet for Matter power consumption measurements #20072

snippets: Added snippet for Matter power consumption measurements #20072

kkasperczyk-no commented Jan 24, 2025

NordicBuilder commented Jan 24, 2025 •

edited

Loading

nordicjm Jan 24, 2025

kkasperczyk-no Jan 24, 2025

nordicjm Jan 24, 2025

kkasperczyk-no Jan 27, 2025 •

edited

Loading

kkasperczyk-no Jan 27, 2025

kkasperczyk-no Jan 27, 2025

NordicBuilder commented Jan 24, 2025

doublemis1 left a comment

ArekBalysNordic left a comment

doublemis1 commented Jan 24, 2025

kkasperczyk-no commented Jan 27, 2025

ArekBalysNordic Jan 27, 2025

maciejbaczmanski Jan 27, 2025

snippets: Added snippet for Matter power consumption measurements #20072

Are you sure you want to change the base?

snippets: Added snippet for Matter power consumption measurements #20072

Conversation

kkasperczyk-no commented Jan 24, 2025

NordicBuilder commented Jan 24, 2025 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

nordicjm Jan 24, 2025

Choose a reason for hiding this comment

kkasperczyk-no Jan 24, 2025

Choose a reason for hiding this comment

nordicjm Jan 24, 2025

Choose a reason for hiding this comment

kkasperczyk-no Jan 27, 2025 • edited Loading

Choose a reason for hiding this comment

kkasperczyk-no Jan 27, 2025

Choose a reason for hiding this comment

kkasperczyk-no Jan 27, 2025

Choose a reason for hiding this comment

NordicBuilder commented Jan 24, 2025

doublemis1 left a comment

Choose a reason for hiding this comment

ArekBalysNordic left a comment

Choose a reason for hiding this comment

doublemis1 commented Jan 24, 2025

kkasperczyk-no commented Jan 27, 2025

ArekBalysNordic Jan 27, 2025

Choose a reason for hiding this comment

maciejbaczmanski Jan 27, 2025

Choose a reason for hiding this comment

NordicBuilder commented Jan 24, 2025 •

edited

Loading

kkasperczyk-no Jan 27, 2025 •

edited

Loading