-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commad status check phase1 #1239
Open
ajayparida
wants to merge
6
commits into
nrfconnect:main
Choose a base branch
from
ajayparida:cmd_status_check_phase1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
916550a
to
95ffd4a
Compare
594c89a
to
026f6f8
Compare
8fb844a
to
abd9581
Compare
abd9581
to
1969638
Compare
1969638
to
bfc67a0
Compare
bfc67a0
to
4503305
Compare
c581edb
to
13b5bd9
Compare
13b5bd9
to
564be30
Compare
e7d4b06
to
4af396b
Compare
b781d78
to
921e956
Compare
5b842cd
to
ba03d8b
Compare
e7c4abe
to
4d5c23d
Compare
4d5c23d
to
eb6b417
Compare
eb6b417
to
9b3886a
Compare
eb6b417
to
6ee198d
Compare
41c4d21
to
ff8f41f
Compare
ff8f41f
to
979cf89
Compare
Validate input parameters passed to API before using them. Signed-off-by: Ajay Parida <ajay.parida@nordicsemi.no>
Added NRF_WIFI_UMAC_CMD_MAX to represent maximum command supported. Signed-off-by: Ajay Parida <ajay.parida@nordicsemi.no>
Structure to store per vif command state information. Signed-off-by: Ajay Parida <ajay.parida@nordicsemi.no>
Check for command pending state for the vif before processing. Signed-off-by: Ajay Parida <ajay.parida@nordicsemi.no>
After sending the command, wait for command status event from firmware. There are two scenarios. Either firmware sends a specific event for the command or a generic event (NRF_WIFI_UMAC_EVENT_CMD_STATUS) where it states about the command failure/success. This commit is related to wait for NRF_WIFI_UMAC_EVENT_CMD_STATUS and it's handling. For commands expecting specific events will be added later. Signed-off-by: Ajay Parida <ajay.parida@nordicsemi.no>
UMAC: [SHEL-2504]:UMAC commands are providing status as failure. Signed-off-by: Rakeswara Kummetha <rakeswara.kummetha@nordicsemi.no>
979cf89
to
1744779
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR from a series or PR to handle command status check for all the commands.
In this PR, only those commands for which no information is passed either to supplicant/user space is handled.
On sending the command, host will wait for the command status to be returned by the firmare.
Depending upon the status/timeout it will return the result to userspace/supplicant.