wifi: Fix watchdog re-arming #1384
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krish2718
requested review from
sachinthegreen,
rado17 and
rlubos
as code owners
krish2718
force-pushed
the
fix_wdog_rearm
branch
from
eee77b7
to
c0252cc
Compare
udaynordic
approved these changes
Jun 13, 2024
sachinthegreen
approved these changes
Jun 17, 2024
Host has a single GPIO line, but RPU ORs two interrupt sources, watchdog and UMAC interrupt, so, clear UMAC interrupt only if there are events in HPQM that triggered the interrupt. Else, we might clear interrupt even before it has been processed, i.e., the next UMAC interrupt. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
Watchdog interrupt should unconditionally be re-armed, even if we are about perform RPU recovery. Only if host has disabled RPU recovery which is compile time then there is not point in re-arming as it would just be ignored anyway. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
force-pushed
the
fix_wdog_rearm
branch
from
c0252cc
to
e354867
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.