-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support yarn berry #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this @Michsior14 - please also add an integration test workflow which leverages this. There is plenty of prior art for you to take inspiration from
Will do it after work hours ;) |
@JamesHenry Integration tests added. |
@Michsior14 thanks a lot for this, please bump the minor version in the root |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
I requested review from @meeroslav on this one as well as I still very jet lagged and I might have missed something 😄
Hey @meeroslav! Any update on the review? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you
I left one minor comment, but it's not a blocker
Super simple implementation for
yarn berry
. Feel free to take parts that you are happy with :)Resolves #24.