fix: support https proxy env variables #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meeroslav
requested changes
Oct 5, 2023
find-successful-workflow.ts
Outdated
| @@ -88,6 +91,23 @@ function reportFailure(branchName) { | |||
| - If no, then you might have changed your git history and those commits no longer exist.`); | |||
| } | |||
|
|
|||
| function createOctokitClient() { | |||
| const OctokitClient = Octokit.plugin( | |||
There was a problem hiding this comment.
Let's just have this as a const e.g. ProxifiedClient and call constructor where needed.
There is another instance of octokit being created at findMergeQueueBranch function.
meeroslav
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment variables which control using a proxy for https requests are respected.
HTTPS_PROXYdefines the server to proxy requests throughNO_PROXYexcludes certain domains from the proxy server