Skip to content

Commit

Permalink
fix(js): update detection of ts solution setup
Browse files Browse the repository at this point in the history
  • Loading branch information
jaysoo committed Jan 9, 2025
1 parent a77e3ef commit 2431f68
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 0 additions & 2 deletions packages/js/src/plugins/typescript/plugin.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2905,7 +2905,6 @@ describe(`Plugin: ${PLUGIN_NAME}`, () => {
},
"outputs": [
"{workspaceRoot}/dist/libs/my-lib",
"{workspaceRoot}/dist/libs/*.tsbuildinfo",
],
"syncGenerators": [
"@nx/js:typescript-sync",
Expand Down Expand Up @@ -3066,7 +3065,6 @@ describe(`Plugin: ${PLUGIN_NAME}`, () => {
"{workspaceRoot}/dist/libs/my-lib/lib.d.ts.map",
"{workspaceRoot}/dist/libs/my-lib/lib.tsbuildinfo",
"{workspaceRoot}/dist/libs/my-lib/other",
"{workspaceRoot}/dist/libs/my-lib/*.tsbuildinfo",
],
"syncGenerators": [
"@nx/js:typescript-sync",
Expand Down
2 changes: 1 addition & 1 deletion packages/js/src/utils/typescript/ts-solution-setup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ function isWorkspaceSetupWithTsSolution(tree: Tree): boolean {
if (
!baseTsconfigJson.compilerOptions ||
!baseTsconfigJson.compilerOptions.composite ||
!baseTsconfigJson.compilerOptions.declaration
baseTsconfigJson.compilerOptions.declaration === false
) {
return false;
}
Expand Down

0 comments on commit 2431f68

Please sign in to comment.