Skip to content

Commit

Permalink
fix(testing): remove --coverage option from jest builder (#2569)
Browse files Browse the repository at this point in the history
the --coverage option was not being used in the builder at all, so provided no change in behavior.
The --codeCoverage option should be used instead

ISSUES CLOSED: #2564
  • Loading branch information
derek-pavao authored Feb 27, 2020
1 parent 7aaa09b commit 60077fb
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 25 deletions.
6 changes: 0 additions & 6 deletions docs/angular/api-jest/builders/jest.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,6 @@ Type: `string`

The path to a Jest config file specifying how to find and execute tests. If no rootDir is set in the config, the directory containing the config file is assumed to be the rootDir for the project. This can also be a JSON-encoded value which Jest will use as configuration

### coverage

Type: `boolean`

Indicates that test coverage information should be collected and reported in the output. This option is also aliased by --collectCoverage. (https://jestjs.io/docs/en/cli#coverage)

### coverageDirectory

Type: `string`
Expand Down
6 changes: 0 additions & 6 deletions docs/react/api-jest/builders/jest.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,6 @@ Type: `string`

The path to a Jest config file specifying how to find and execute tests. If no rootDir is set in the config, the directory containing the config file is assumed to be the rootDir for the project. This can also be a JSON-encoded value which Jest will use as configuration

### coverage

Type: `boolean`

Indicates that test coverage information should be collected and reported in the output. This option is also aliased by --collectCoverage. (https://jestjs.io/docs/en/cli#coverage)

### coverageDirectory

Type: `string`
Expand Down
6 changes: 0 additions & 6 deletions docs/web/api-jest/builders/jest.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,6 @@ Type: `string`

The path to a Jest config file specifying how to find and execute tests. If no rootDir is set in the config, the directory containing the config file is assumed to be the rootDir for the project. This can also be a JSON-encoded value which Jest will use as configuration

### coverage

Type: `boolean`

Indicates that test coverage information should be collected and reported in the output. This option is also aliased by --collectCoverage. (https://jestjs.io/docs/en/cli#coverage)

### coverageDirectory

Type: `string`
Expand Down
2 changes: 0 additions & 2 deletions packages/jest/src/builders/jest/jest.impl.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ describe('Jest Builder', () => {
colors: false,
reporters: ['/test/path'],
verbose: false,
coverage: false,
coverageReporters: 'test',
coverageDirectory: '/test/path',
watch: false
Expand Down Expand Up @@ -179,7 +178,6 @@ describe('Jest Builder', () => {
colors: false,
reporters: ['/test/path'],
verbose: false,
coverage: false,
coverageReporters: 'test',
coverageDirectory: '/test/path',
testResultsProcessor: 'results-processor',
Expand Down
1 change: 0 additions & 1 deletion packages/jest/src/builders/jest/jest.impl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ export interface JestBuilderOptions extends JsonObject {
colors?: boolean;
reporters?: string[];
verbose?: boolean;
coverage?: boolean;
coverageReporters?: string;
coverageDirectory?: string;
testResultsProcessor?: string;
Expand Down
4 changes: 0 additions & 4 deletions packages/jest/src/builders/jest/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,6 @@
"description": "Display individual test results with the test suite hierarchy. (https://jestjs.io/docs/en/cli#verbose)",
"type": "boolean"
},
"coverage": {
"description": "Indicates that test coverage information should be collected and reported in the output. This option is also aliased by --collectCoverage. (https://jestjs.io/docs/en/cli#coverage)",
"type": "boolean"
},
"coverageReporters": {
"description": "A list of reporter names that Jest uses when writing coverage reports. Any istanbul reporter",
"type": "string"
Expand Down

0 comments on commit 60077fb

Please sign in to comment.