fix(core): fix broken path elevation in npm lockfile pruning (#15833)

nrwl · Mar 22, 2023 · 8cd410a · 8cd410a · vercel · Mar 22, 2023
1 parent c7e49c5
commit 8cd410a
Showing 1 changed file with 14 additions and 4 deletions.
diff --git a/packages/nx/src/lock-file/npm-parser.ts b/packages/nx/src/lock-file/npm-parser.ts
@@ -580,10 +580,20 @@ function elevateNestedPaths(
       `${segs.join('/node_modules/')}/node_modules/${packageName}`;
 
     // check if grandparent has the same package
-    while (
-      segments.length > 1 &&
-      !result.has(getNewPath(segments.slice(0, -1)))
-    ) {
+    const shouldElevate = (segs: string[]) => {
+      const newPath = getNewPath(segs.slice(0, -1));
+      if (result.has(newPath)) {
+        const match = result.get(newPath);
+        const source = remappedPackages.get(path);
+        return (
+          match.valueV1?.version === source.valueV1?.version &&
+          match.valueV3?.version === source.valueV3?.version
+        );
+      }
+      return true;
+    };
+
+    while (segments.length > 1 && shouldElevate(segments)) {
       segments.pop();
     }
     const newPath = getNewPath(segments);