fix(schematics): remove default prop for viewEncapsulation option flag

Also adds specs for confirming use with no flag and with flag
nrwl · Dec 14, 2017 · b46eb1c · b46eb1c
1 parent 4aa42e4
commit b46eb1c
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 4 deletions.
diff --git a/packages/bazel/src/app/schema.json b/packages/bazel/src/app/schema.json
@@ -31,8 +31,7 @@
     "viewEncapsulation": {
       "description": "Specifies the view encapsulation strategy.",
       "enum": ["Emulated", "Native", "None"],
-      "type": "string",
-      "default": "None"
+      "type": "string"
     },
     "changeDetection": {
       "description": "Specifies the change detection strategy.",

diff --git a/packages/schematics/src/collection/app/app.spec.ts b/packages/schematics/src/collection/app/app.spec.ts
@@ -148,4 +148,25 @@ describe('app', () => {
       );
     });
   });
+
+  describe('view encapsulation', () => {
+    it('should not set Component encapsulation metadata if option flag not included', () => {
+      const tree = schematicRunner.runSchematic(
+        'app',
+        { name: 'myApp', npmScope: 'nrwl', directory: 'myDir' },
+        appTree
+      );
+      expect(getFileContent(tree, 'apps/my-dir/my-app/src/app/app.component.ts')).not.toContain('encapsulation: ');
+    });
+    it('should set Component encapsulation metadata if option flag is included', () => {
+      const tree = schematicRunner.runSchematic(
+        'app',
+        { name: 'myApp', npmScope: 'nrwl', directory: 'myDir', viewEncapsulation: 'Native' },
+        appTree
+      );
+      expect(getFileContent(tree, 'apps/my-dir/my-app/src/app/app.component.ts')).toContain(
+        'encapsulation: ViewEncapsulation.Native'
+      );
+    });
+  });
 });
diff --git a/packages/schematics/src/collection/app/schema.json b/packages/schematics/src/collection/app/schema.json
@@ -36,8 +36,7 @@
     "viewEncapsulation": {
       "description": "Specifies the view encapsulation strategy.",
       "enum": ["Emulated", "Native", "None"],
-      "type": "string",
-      "default": "None"
+      "type": "string"
     },
     "changeDetection": {
       "description": "Specifies the change detection strategy.",