feat(react): Treat window and var library types the same (#20597)

packages/react/src/module-federation/with-module-federation.ts

@@ -3,6 +3,9 @@ import { getModuleFederationConfig } from './utils';
 import type { AsyncNxComposableWebpackPlugin } from '@nx/webpack';
 import ModuleFederationPlugin = require('webpack/lib/container/ModuleFederationPlugin');
 
+const isVarOrWindow = (libType?: string) =>
+  libType === 'var' || libType === 'window';
+
 /**
  * @param {ModuleFederationConfig} options
  * @return {Promise<AsyncNxComposableWebpackPlugin>}
@@ -12,12 +15,13 @@ export async function withModuleFederation(
 ): Promise<AsyncNxComposableWebpackPlugin> {
   const { sharedDependencies, sharedLibraries, mappedRemotes } =
     await getModuleFederationConfig(options);
+  const isGlobal = isVarOrWindow(options.library?.type);
 
   return (config, ctx) => {
     config.output.uniqueName = options.name;
     config.output.publicPath = 'auto';
 
-    if (options.library?.type === 'var') {
+    if (isGlobal) {
       config.output.scriptType = 'text/javascript';
     }
 
@@ -27,7 +31,7 @@ export async function withModuleFederation(
 
     config.experiments = {
       ...config.experiments,
-      outputModule: !(options.library?.type === 'var'),
+      outputModule: !isGlobal,
     };
 
     config.plugins.push(
@@ -46,7 +50,7 @@ export async function withModuleFederation(
          *  { appX: 'appX@http://localhost:3001/remoteEntry.js' }
          *  { appY: 'appY@http://localhost:3002/remoteEntry.js' }
          */
-        ...(options.library?.type === 'var' ? { remoteType: 'script' } : {}),
+        ...(isGlobal ? { remoteType: 'script' } : {}),
       }),
       sharedLibraries.getReplacementPlugin()
     );