chore(misc): fix e2es for cache and run (#21561)

nrwl · Feb 2, 2024 · d9b4cb2 · d9b4cb2
1 parent bc6e58f
commit d9b4cb2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/e2e/nx-run/src/cache.test.ts b/e2e/nx-run/src/cache.test.ts
@@ -18,8 +18,7 @@ describe('cache', () => {
 
   afterEach(() => cleanupProject());
 
-  // TODO(crystal, @Cammisuli): Investigate why this is failing
-  xit('should cache command execution', async () => {
+  it('should cache command execution', async () => {
     const myapp1 = uniq('myapp1');
     const myapp2 = uniq('myapp2');
     runCLI(`generate @nx/web:app ${myapp1}`);
@@ -123,9 +122,11 @@ describe('cache', () => {
     const originalNxJson = readFile('nx.json');
     updateFile('nx.json', (c) => {
       const nxJson = JSON.parse(c);
-      for (const key in nxJson.targetDefaults ?? {}) {
-        delete nxJson.targetDefaults[key].cache;
-      }
+      nxJson.targetDefaults = {
+        build: {
+          cache: false,
+        },
+      };
       return JSON.stringify(nxJson, null, 2);
     });
 

diff --git a/e2e/nx-run/src/run.test.ts b/e2e/nx-run/src/run.test.ts
@@ -765,8 +765,7 @@ describe('Nx Running Tests', () => {
         expect(output).toContain('Nx read the output from the cache');
       });
 
-      // TODO(crystal, @Cammisuli): Investigate why this is failing
-      xit('should read outputs', () => {
+      it('should read outputs', () => {
         const nodeCommands = [
           "const fs = require('fs')",
           "fs.mkdirSync('../../tmp/exec-outputs-test', {recursive: true})",
@@ -783,6 +782,7 @@ describe('Nx Running Tests', () => {
             nx: {
               targets: {
                 build: {
+                  cache: true,
                   outputs: ['{workspaceRoot}/tmp/exec-outputs-test'],
                 },
               },